Update SE for Symfony 3.0 #850

fabpot · 2015-09-16T07:55:06Z

No description provided.

gnugat · 2015-09-16T08:55:34Z

Test classes could be autoloaded only in a development environment by moving them from src/AppBundle/Tests to tests and adding a autoload-dev section in composer.
What do you think about this suggestion?

stof · 2015-09-16T09:38:39Z

I agree with @gnugat here. Separating tests from the runtime source is a good idea IMO

stof · 2015-09-16T09:39:20Z

.gitignore

 /app/config/parameters.yml
-/app/logs/*
-!app/cache/.gitkeep
-!app/logs/.gitkeep
 /app/phpunit.xml


should be changed too as we moved the phpunit config at the root

stof · 2015-09-16T09:41:23Z

this also requires an update of the HttpKernel component to change the location of the cache and logs

weaverryan · 2015-09-17T03:16:02Z

@gnugat @stof @fabpot is just making the structure match what was decided in #584 - so we should focus only on that (and open a new issue about tests for discussion).

Tobion · 2015-09-17T12:45:50Z

Created #855 for tests

fabpot · 2015-09-22T15:10:59Z

Needs more work

hacfi · 2015-09-22T21:24:33Z

.gitignore

@@ -1,11 +1,10 @@
-/web/bundles/
 /app/bootstrap.php.cache


this is moved to /var/ as well

Tobion · 2015-09-22T22:14:42Z

I'd recommend to merge #854 first.

weaverryan · 2015-09-23T01:32:56Z

bin/console

@@ -7,8 +7,8 @@

 set_time_limit(0);

-require_once __DIR__.'/bootstrap.php.cache';
-require_once __DIR__.'/AppKernel.php';
+require_once dirname(__DIR__).'/app/bootstrap.php.cache';


As others have said, this lives in /var - and the same change will need to go in the front controllers.

fabpot · 2015-09-23T08:04:33Z

Besides the new directory structure, I've made another change that should help: sessions are now stored outside of the cache/ directory, and directly into the var/ dir.

Pierstoval · 2015-09-23T08:06:30Z

@fabpot Why is it better to store the sessions in var instead of cache ?

fabpot · 2015-09-23T08:10:21Z

@Pierstoval Because clearing the session store should be decoupled from clearing the Symfony cache, the two are not related. And when using cache:clear, all the cache is flushed. Also, storing sessions in the cache has some problems with Windows (see symfony/symfony#15862 -- not confirmed though)

fabpot · 2015-09-23T08:11:49Z

This one is ready for a last review before merge.

yguedidi · 2015-09-23T08:25:06Z

bin/symfony_requirements

@@ -1,6 +1,7 @@
+#!/usr/bin/env php
 <?php


~~Are you sure about the file permissions change?~~ Oups.

michaelcullum · 2015-09-23T09:21:58Z

Should var/sessions/ not also have a .gitkeep and be added to the .gitignore?

fabpot · 2015-09-23T09:26:15Z

@michaelcullum right, fixed

This PR was merged into the 3.0-dev branch. Discussion ---------- Update SE for Symfony 3.0 Commits ------- dcf4ead move sessions outside of the cache directory 693e1f7 moved to the 3.0 directory structure 4a86c13 removed obsolete files 43e379e updated deps to make it possible to install SE with Symfony 3.0

This PR was merged into the 2.8 branch. Discussion ---------- Use a proper version constraint Any reason why this wasn't used already? I noticed this when looking at #850. Commits ------- 8d04960 Use a proper version constraint

This PR was merged into the 3.0-dev branch. Discussion ---------- Use Kernel::getEnvironment() to keep consistency Hi there! The PR #850 introduced the use of the variable `$this->environment` to get the environment, but we already use the method `Kernel::getEnvironment()`, this PR fixes this to keep consistency. Please review this before the Symfony 3.0 release. Commits ------- d7320f7 Use Kernel::getEnvironment() to keep consistency

fabpot force-pushed the towards-30 branch 2 times, most recently from e6a04cb to 5ce1803 Compare September 16, 2015 08:02

stof reviewed Sep 16, 2015
View reviewed changes

fabpot force-pushed the towards-30 branch 2 times, most recently from f05ffa9 to 9dbbaae Compare September 16, 2015 10:31

GrahamCampbell mentioned this pull request Sep 16, 2015

Use a proper version constraint #852

Merged

fabpot force-pushed the towards-30 branch from 9dbbaae to adbba6b Compare September 22, 2015 15:07

fabpot changed the title ~~[WIP] Update SE for Symfony 3.0~~ Update SE for Symfony 3.0 Sep 22, 2015

fabpot force-pushed the towards-30 branch from adbba6b to ad859b4 Compare September 22, 2015 15:10

fabpot force-pushed the towards-30 branch 4 times, most recently from 4b7d8c1 to 93ec6da Compare September 22, 2015 17:27

hacfi reviewed Sep 22, 2015
View reviewed changes

.gitignore

@@ -1,11 +1,10 @@

/web/bundles/

/app/bootstrap.php.cache

Copy link

hacfi Sep 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is moved to /var/ as well

weaverryan reviewed Sep 23, 2015
View reviewed changes

fabpot force-pushed the towards-30 branch 2 times, most recently from f50ffc5 to 5262286 Compare September 23, 2015 07:58

fabpot added 2 commits September 23, 2015 10:08

updated deps to make it possible to install SE with Symfony 3.0

43e379e

removed obsolete files

4a86c13

moved to the 3.0 directory structure

693e1f7

fabpot force-pushed the towards-30 branch from 9ee5ec7 to c84af8b Compare September 23, 2015 08:08

yguedidi reviewed Sep 23, 2015
View reviewed changes

bin/symfony_requirements

@@ -1,6 +1,7 @@

#!/usr/bin/env php

<?php

Copy link

yguedidi Sep 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~Are you sure about the file permissions change?~~ Oups.

move sessions outside of the cache directory

dcf4ead

fabpot force-pushed the towards-30 branch from c84af8b to dcf4ead Compare September 23, 2015 09:25

fabpot merged commit dcf4ead into symfony:master Sep 23, 2015

dosten mentioned this pull request Nov 28, 2015

Use Kernel::getEnvironment() to keep consistency #889

Merged

Uh oh!

Update SE for Symfony 3.0 #850

Update SE for Symfony 3.0 #850

Uh oh!

Conversation

fabpot commented Sep 16, 2015

Uh oh!

gnugat commented Sep 16, 2015

Uh oh!

stof commented Sep 16, 2015

Uh oh!

stof Sep 16, 2015

Choose a reason for hiding this comment

Uh oh!

stof commented Sep 16, 2015

Uh oh!

weaverryan commented Sep 17, 2015

Uh oh!

Tobion commented Sep 17, 2015

Uh oh!

fabpot commented Sep 22, 2015

Uh oh!

hacfi Sep 22, 2015

Choose a reason for hiding this comment

Uh oh!

Tobion commented Sep 22, 2015

Uh oh!

weaverryan Sep 23, 2015

Choose a reason for hiding this comment

Uh oh!

fabpot commented Sep 23, 2015

Uh oh!

Pierstoval commented Sep 23, 2015

Uh oh!

fabpot commented Sep 23, 2015

Uh oh!

fabpot commented Sep 23, 2015

Uh oh!

yguedidi Sep 23, 2015

Choose a reason for hiding this comment

Uh oh!

michaelcullum commented Sep 23, 2015

Uh oh!

fabpot commented Sep 23, 2015

Uh oh!

Uh oh!